feat(speakers): add has_pending_presentations filter for speakers and submitters by romanetar · Pull Request #562 · OpenStackweb/summit-api

romanetar · 2026-06-22T13:43:20Z

ref https://app.clickup.com/t/86badvupk

Summary by CodeRabbit

New Features
- Added filtering capability to filter speakers and submitters by pending presentation status across all relevant endpoints, including speakers list, submitters list, CSV exports, activity counts, and bulk email operations.
Tests
- Added test coverage for pending presentation filtering functionality for both speakers and submitters.

coderabbitai · 2026-06-22T13:43:41Z

Warning

Review limit reached

@romanetar, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 1 second. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5056be20-4852-4fba-8b0e-a0127bc1338d

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce716b and 1dc2b14.

📒 Files selected for processing (10)

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSpeakersApiController.php
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmittersApiController.php
app/Jobs/Emails/PresentationSubmissions/ProcessSpeakersEmailRequestJob.php
app/Jobs/Emails/PresentationSubmissions/ProcessSubmittersEmailRequestJob.php
app/Repositories/Summit/DoctrineMemberRepository.php
app/Repositories/Summit/DoctrineSpeakerRepository.php
app/Services/Model/Imp/SpeakerService.php
app/Services/Model/Imp/SubmitterService.php
tests/oauth2/OAuth2SummitSpeakersApiTest.php
tests/oauth2/OAuth2SummitSubmittersApiTest.php

📝 Walkthrough

Walkthrough

The PR adds a has_pending_presentations boolean filter to speaker and submitter API endpoints (getSpeakers, getSpeakersActivitiesCount, getSpeakersCSV, getAllBySummit, getAllBySummitCSV, send, getSubmittersActivitiesCount). Repositories implement the filter via EXISTS/NOT EXISTS Doctrine SQL subqueries checking for unpublished, unselected presentations. Integration tests verify both paths.

Changes

has_pending_presentations filter

Layer / File(s)	Summary
Repository EXISTS/NOT EXISTS predicate logic `app/Repositories/Summit/DoctrineSpeakerRepository.php`, `app/Repositories/Summit/DoctrineMemberRepository.php`	Both repositories add a `DoctrineSwitchFilterMapping` for `has_pending_presentations`. For `"true"`, EXISTS subqueries match unpublished presentations linked to speaker/member that are absent from `SummitSelectedPresentation` Group/Session lists; `"false"` inverts with NOT EXISTS. Both splice in `$extraSelectionStatusFilter` when available. The speaker variant handles both direct speaker links and moderator links.
Speaker controller filter parsing and validation `app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSpeakersApiController.php`	Adds `has_pending_presentations` with `==` operator to filter parser configs and `in:true,false` validation rules across `getSpeakers`, `getSpeakersActivitiesCount`, and `getSpeakersCSV`. OpenAPI filter descriptions are updated for all three endpoints.
Submitter controller filter parsing and validation `app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmittersApiController.php`	Adds `has_pending_presentations` with `==` operator and `in:true,false` validation across `getAllBySummit`, `getAllBySummitCSV`, `send`, and `getSubmittersActivitiesCount`. The `getSubmittersActivitiesCount` OpenAPI description is also updated.
Integration tests `tests/oauth2/OAuth2SummitSpeakersApiTest.php`, `tests/oauth2/OAuth2SummitSubmittersApiTest.php`	New test methods create an unpublished, unselected presentation, call the list endpoint with `has_pending_presentations==true`, and assert HTTP 200 with non-empty `data`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

OpenStackweb/summit-api#543: Adds the getSpeakersActivitiesCount / getSubmittersActivitiesCount endpoints and underlying repository logic that this PR extends with the has_pending_presentations filter.

Suggested reviewers

smarcet

Poem

🐰 A pending talk needs a filter, you see,
So speakers with drafts can be found easily!
EXISTS and NOT EXISTS — the queries do hop,
Through groups and through sessions that haven't yet stopped.
The bunny approves: no stray talks shall hide! 🎤

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 31.25% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title clearly and concisely describes the main change: adding a new filter field `has_pending_presentations` to speakers and submitters endpoints, which is directly reflected in the changeset across controllers, repositories, and tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/speakers-grid-new-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-22T13:45:05Z

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-562/

This page is automatically updated on each push to this PR.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSpeakersApiController.php`:
- Line 254: The protected route's OpenAPI parameter description for the speakers
endpoint needs to be updated to match the filter options added on line 254.
Locate the description field for the protected speakers route (the authenticated
`/api/v1/summits/{id}/speakers` endpoint) and add `has_pending_presentations` to
the list of supported filters in the same format as the public route, ensuring
both routes advertise the same available filter parameters.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fdcf26d7-1680-4902-b468-48a4e28f67df

📥 Commits

Reviewing files that changed from the base of the PR and between 5a64bc5 and 7ce716b.

📒 Files selected for processing (6)

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSpeakersApiController.php
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmittersApiController.php
app/Repositories/Summit/DoctrineMemberRepository.php
app/Repositories/Summit/DoctrineSpeakerRepository.php
tests/oauth2/OAuth2SummitSpeakersApiTest.php
tests/oauth2/OAuth2SummitSubmittersApiTest.php

… submitters Signed-off-by: romanetar <roman_ag@hotmail.com>

github-actions · 2026-06-22T14:15:10Z

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-562/

This page is automatically updated on each push to this PR.

coderabbitai Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSpeakersApiController.php

feat(speakers): add has_pending_presentations filter for speakers and…

1dc2b14

… submitters Signed-off-by: romanetar <roman_ag@hotmail.com>

romanetar force-pushed the feature/speakers-grid-new-filter branch from 7ce716b to 1dc2b14 Compare June 22, 2026 14:13

romanetar requested a review from smarcet June 22, 2026 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(speakers): add has_pending_presentations filter for speakers and submitters#562

feat(speakers): add has_pending_presentations filter for speakers and submitters#562
romanetar wants to merge 1 commit into
mainfrom
feature/speakers-grid-new-filter

romanetar commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

romanetar commented Jun 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

romanetar commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading